Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernel-sdfat: Add to repo #6238

Closed
wants to merge 1 commit into from
Closed

kernel-sdfat: Add to repo #6238

wants to merge 1 commit into from

Conversation

diizzyy
Copy link
Contributor

@diizzyy diizzyy commented Jun 8, 2018

Maintainer:
Compile tested: mvebu, Linksys WRT3200ACM, OpenWrt master
Run tested: mvebu, Linksys WRT3200ACM, OpenWrt master

Description:
Add kernel-sdfat to repo
Patch adapted from cryptomilk/kernel-sdfat#4

Signed-off-by: Daniel Engberg [email protected]

@diizzyy
kernel-sdfat: Add to repo
6634ad0 
Add kernel-sdfat to repo
Patch adapted from cryptomilk/kernel-sdfat#4

Signed-off-by: Daniel Engberg <[email protected]>
@diizzyy
Copy link
Contributor Author

diizzyy commented Jun 8, 2018

@yousong @neheb @pprindeville

The only issue I'm having is getting this filesystem driver to properly announce supported filesystems to the kernel but it probably boils down to my limited knowledge in the end. ;-)

As far as I can tell they're defined here:
https://github.com/cryptomilk/kernel-sdfat/blob/master/sdfat.c#L75

...and turned on by default here:
https://github.com/cryptomilk/kernel-sdfat/blob/master/Kconfig#L18

However, I'm not sure if Kconfig gets imported by default or if I need to use KCONFIG entries.

It currently looks like this which seems to confuse block-mount and friends.

root@LEDE:~# cat /proc/filesystems
nodev   sysfs
nodev   rootfs
nodev   tmpfs
nodev   bdev
nodev   proc
nodev   debugfs
nodev   sockfs
nodev   bpf
nodev   pipefs
nodev   ramfs
nodev   devpts
        ext3
        ext2
        ext4
        squashfs
nodev   jffs2
nodev   overlay
        f2fs
nodev   ubifs
        sdfat

Fri Jun  8 07:18:27 2018 kern.notice kernel: [ 1151.995716] sd 2:0:0:0: [sda] Attached SCSI removable disk
Fri Jun  8 07:18:27 2018 daemon.err block: No "mount.exfat" utility available

It works if you try to mount manually (busybox mount) however it seems to be a bit noisy but that's because it tries all available filesystems?

Fri Jun  8 07:04:56 2018 kern.info kernel: [  341.415388] F2FS-fs (sda1): Magic Mismatch, valid(0xf2f52010) - read(0x0)
Fri Jun  8 07:04:56 2018 kern.err kernel: [  341.422222] F2FS-fs (sda1): Can't find valid F2FS filesystem in 1th superblock
Fri Jun  8 07:04:56 2018 kern.info kernel: [  341.429827] F2FS-fs (sda1): Magic Mismatch, valid(0xf2f52010) - read(0x0)
Fri Jun  8 07:04:56 2018 kern.err kernel: [  341.436645] F2FS-fs (sda1): Can't find valid F2FS filesystem in 2th superblock
Fri Jun  8 07:04:56 2018 kern.info kernel: [  341.443953] F2FS-fs (sda1): Magic Mismatch, valid(0xf2f52010) - read(0x0)
Fri Jun  8 07:04:56 2018 kern.err kernel: [  341.450778] F2FS-fs (sda1): Can't find valid F2FS filesystem in 1th superblock
Fri Jun  8 07:04:56 2018 kern.info kernel: [  341.458035] F2FS-fs (sda1): Magic Mismatch, valid(0xf2f52010) - read(0x0)
Fri Jun  8 07:04:56 2018 kern.err kernel: [  341.464851] F2FS-fs (sda1): Can't find valid F2FS filesystem in 2th superblock
Fri Jun  8 07:04:56 2018 kern.info kernel: [  341.472582] [SDFAT](sda1[8:1]): trying to mount...
Fri Jun  8 07:04:56 2018 kern.info kernel: [  341.477653] [SDFAT](sda1[8:1]): set logical sector size  : 512
Fri Jun  8 07:04:56 2018 kern.info kernel: [  341.483514] [SDFAT](sda1[8:1]): detected volume info     : exfat (bps : 512, spc : 64, data start : 4096, aligned)
Fri Jun  8 07:04:56 2018 kern.info kernel: [  341.493928] [SDFAT](sda1[8:1]): detected volume size     : 7550 MB (disk_size : 7552 MB)
Fri Jun  8 07:04:57 2018 kern.info kernel: [  341.517224] [SDFAT](sda1[8:1]): mounted successfully!

A hack would be to symlink mount as mount.exfat but that seems like a strange solution as other modules works fine without that workaround.

@hnyman
Copy link
Contributor

hnyman commented Jun 11, 2018

@diizzyy
If you really want this into repo, at least make yourself as the maintainer. That is the basic requirement for new packages. We already have abandonware (also from you), so let's not create more.

@diizzyy
Copy link
Contributor Author

diizzyy commented Jun 11, 2018

@hnyman
This is a replacement for exfat-nofuse which is probably of interest for quite many.

Regarding abandonware:
To be honest, I wouldn't mind removing some packages (inadyn is probably the only one that isn't up to date to my knowledge) and others have been picked up except inadyn and tio. It would probably be a good idea to have an open (and active) discussion about on how to handle abandoned packages/or when the maintainer doesn't reply within a reasonable amount of time which would solve quite a lot of outdated packages.

@diizzyy
Copy link
Contributor Author

diizzyy commented Jun 30, 2018

Let's close this for now

@diizzyy diizzyy closed this Jun 30, 2018
@diizzyy diizzyy mentioned this pull request Oct 15, 2018
Merged
@diizzyy diizzyy mentioned this pull request Dec 22, 2018
Closed
@dengqf6
Copy link
Contributor

dengqf6 commented Feb 14, 2019 •
edited
Loading

sdfat now supports 4.19
cryptomilk/kernel-sdfat@4f65bdd

@diizzyy
Copy link
Contributor Author

diizzyy commented Feb 14, 2019

@dengqf6
Cool, I still don't know how the configuration stuff works for out of kernel modules however :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
New package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diizzyy @hnyman @dengqf6